implementation of redis datastore#1454
Merged
rfecher merged 7 commits intolocationtech:masterfrom Nov 2, 2018
Merged
Conversation
jdgarrett
requested changes
Oct 31, 2018
Contributor
jdgarrett
left a comment
There was a problem hiding this comment.
Mostly extra comments need to be addressed. There was one TODO that could affect mergeData, and one issue with the RedisStoreTestEnvironment.
| private Iterator<T> transformAndFilter( | ||
| final Collection<ScoredEntry<GeoWaveRedisPersistedRow>> result, | ||
| final byte[] partitionKey ) { | ||
| // final List<ScoredEntry<GeoWaveRedisPersistedRow>> list = new |
| public class RedisOperations implements | ||
| MapReduceDataStoreOperations | ||
| { | ||
| // private final static int WRITE_RESPONSE_THREAD_SIZE = 16; |
Contributor
Author
There was a problem hiding this comment.
ahh, yeah another block to remove
| gwNamespace = options.getGeowaveNamespace(); | ||
| } | ||
| this.options = options; | ||
| // this.options = options; |
| private void deleteByPattern( | ||
| final String pattern ) { | ||
| final RKeys keySet = client.getKeys(); | ||
| // final String[] keys = Iterators.toArray( |
| @Override | ||
| public void close() | ||
| throws Exception { | ||
| // TODO its unclear whether this is necessary |
Contributor
There was a problem hiding this comment.
If this is necessary, it may need to be done on flush() as well to make sure the delete happens before the write when merging rows.
Contributor
Author
There was a problem hiding this comment.
yeah, I agree, I actually did look at this unnecessary block of code and debated deleting it a couple times - I should write some test to see if its necessary and then either delete or not
Contributor
Author
There was a problem hiding this comment.
wrote some code - its unncecessary
RedisServer server= RedisServer.builder().port(
6379).setting(
"bind 127.0.0.1") // secure + prevents popups on Windows
.setting(
"maxmemory 512M")
.setting(
"timeout 30000")
.build();
server.start();
Config config = new Config();
config.useSingleServer().setAddress("redis://127.0.0.1:6379");
RedissonClient r = Redisson.create(config);
r.getKeys().getKeys().forEach(k -> System.err.println(k));
RList list = r.getList("test");
System.err.println("1");
r.getKeys().getKeys().forEach(k -> System.err.println(k));
list.add(new Integer(100));
System.err.println("2");
r.getKeys().getKeys().forEach(k -> System.err.println(k));
list.remove(new Integer(100));
r.getKeys().getKeys().forEach(k -> System.err.println(k));
System.err.println("3");
list.delete();
System.err.println("4");
r.getKeys().getKeys().forEach(k -> System.err.println(k));
server.stop();
produces:
1
2
test
3
4
| public static Collection<ScoredEntry<GeoWaveRedisPersistedRow>> groupByRow( | ||
| final Collection<ScoredEntry<GeoWaveRedisPersistedRow>> result, | ||
| final boolean sortByTime ) { | ||
| // final List<ScoredEntry<GeoWaveRedisPersistedRow>> list = new |
|
|
||
| @Override | ||
| public void setup() { | ||
| // DynamoDB IT's rely on an external dynamo local process |
|
|
||
| @Override | ||
| protected GeoWaveStoreType getStoreType() { | ||
| return GeoWaveStoreType.DYNAMODB; |
Contributor
Author
There was a problem hiding this comment.
apparently thats fairly unnecessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.