Merged
Conversation
79749b1 to
3af012e
Compare
Contributor
Author
|
Geometry UDTs now working within javaspark + pyspark. Did a rough maven module + build for the python package, and integrated it with existing bootstrap for jupyter + jupyterhub. Final location of package for distribution and how it's worked into master build needs to be solidified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of Geometry UDTs. PR commits still need to be squashed, but currently trying to solve a issue that will require some more development.
Currently all tests are passing locally, serialization + deserialization of UDT works in java RDDs and DataFrames. The current issue is a frontend display issue from notebooks with pyspark + pixiedust. We normally display the dataframe using pixiedusts display function i.e. display(df)
However, when trying to display with pixiedust the job fails because of how Spark tries to first convert the type to/from JSON before displaying. After more digging this will require a python UDT to be created in addition to the Java/Scala UDT. We should be able to use the Shapely library as a backing serialized object for each geometry type in python. This additional change may take some additional time just because some portions of how to work a python package into the current build process and deploy it properly with jupyter + spark are unclear to me.
Alternatively, We can use the builtin dataframe display
i.e. df.show()
Which will work and display the geometries in their WKT string format, but that makes our use of pixiedust relatively pointless in the notebooks beyond a job status tracker. I would ideally like the python package + UDT as the long-term solution. Going to attempt to get everything in place over the weekend.