Added more complete parsing functionality to REST services#1355
Merged
rfecher merged 6 commits intolocationtech:masterfrom Jul 18, 2018
Merged
Added more complete parsing functionality to REST services#1355rfecher merged 6 commits intolocationtech:masterfrom
rfecher merged 6 commits intolocationtech:masterfrom
Conversation
added 5 commits
July 11, 2018 12:38
…ST responses before)
emacthecav
reviewed
Jul 12, 2018
|
|
||
|
|
||
| // The following case should probably return a 404 based on the | ||
| // situation described in the test description |
Contributor
There was a problem hiding this comment.
Is this just a copy paste issue?
emacthecav
reviewed
Jul 12, 2018
|
|
||
| // The following case should probably return a 404 based on the | ||
| // situation described in the test description | ||
| TestUtils |
Contributor
There was a problem hiding this comment.
Is this just a copy paste issue?
emacthecav
reviewed
Jul 12, 2018
| "nonexistent-adapter")); | ||
|
|
||
|
|
||
| // The following case should probably return a 404 based on the |
emacthecav
reviewed
Jul 12, 2018
| "COUNT_DATA")); | ||
|
|
||
|
|
||
| // The following case should probably return a 404 based on the |
Contributor
There was a problem hiding this comment.
This comment seems to be everywhere
rfecher
reviewed
Jul 16, 2018
| strValue); | ||
| strValue.toUpperCase()); | ||
| } | ||
| else if (CQLFilterOptionProvider.FilterParameter.class.isAssignableFrom(type)) { |
Contributor
There was a problem hiding this comment.
instead of adding geowave-adapter-vector and special casing this one parameter that requires a converter, it'd be better to use reflection to find the annotations with a converter and convert them (so it would hypothetically work for any parameter with a converter)
rfecher
approved these changes
Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.