Skip to content

REST services parameter handling enhancements#1350

Merged
rfecher merged 1 commit intolocationtech:masterfrom
dbazile:restservices-params-handling
Jun 29, 2018
Merged

REST services parameter handling enhancements#1350
rfecher merged 1 commit intolocationtech:masterfrom
dbazile:restservices-params-handling

Conversation

@dbazile
Copy link
Copy Markdown
Contributor

@dbazile dbazile commented Jun 21, 2018

An attempt to smooth out some of the edges around the REST API and how it handles parameter parsing, specifically:

  • Fixes errors from unconverted assignments of primitive Object[] arrays to fields
  • Improves error logging for diagnostics/troubleshooting
  • Adds null checks for optional/missing parameters

In `/v0/ingest/localToGW`--and likely other endpoints for operations using
primitive array parameters--unconverted assignment throws this error:

```
java.lang.IllegalArgumentException: Can not set [Ljava.lang.String; field mil.nga.giat.geowave.core.ingest.local.LocalInputCommandLineOptions.extensions to [Ljava.lang.Object;
``` (+2 squashed commits)
Squashed commits:
[6ca6f1109b0] Improve error logging
[b8b89970a7e] Add null checks for missing/optional params
@dbazile dbazile closed this Jun 21, 2018
@dbazile dbazile deleted the restservices-params-handling branch June 21, 2018 16:04
@dbazile dbazile restored the restservices-params-handling branch June 21, 2018 16:04
@dbazile
Copy link
Copy Markdown
Contributor Author

dbazile commented Jun 21, 2018

Arg, mis-clicked. :)

@dbazile dbazile reopened this Jun 21, 2018
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 21, 2018

Coverage Status

Coverage increased (+0.9%) to 47.167% when pulling 04c04b9 on dbazile:restservices-params-handling into adf9059 on locationtech:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.3%) to 44.974% when pulling 04c04b9 on dbazile:restservices-params-handling into adf9059 on locationtech:master.

@rfecher rfecher merged commit 585491e into locationtech:master Jun 29, 2018
@dbazile dbazile deleted the restservices-params-handling branch June 29, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants