Add caching to data statistics to improve small query performance.#1349
Merged
rfecher merged 1 commit intolocationtech:masterfrom Jun 29, 2018
Merged
Add caching to data statistics to improve small query performance.#1349rfecher merged 1 commit intolocationtech:masterfrom
rfecher merged 1 commit intolocationtech:masterfrom
Conversation
Signed-off-by: Johnathan Garrett <jd@prominentedge.com>
rfecher
reviewed
Jun 28, 2018
| final ByteArrayId primaryId, | ||
| final ByteArrayId secondaryId ) { | ||
| // the secondaryId is optional so check for null | ||
| StringBuilder sb = new StringBuilder( |
Contributor
There was a problem hiding this comment.
curious if there's a driver/motivation for this change?
Contributor
Author
There was a problem hiding this comment.
Earlier in the development of this patch I had made a change that appended all the authorizations to the combined key, making stringbuilder more efficient. But that was later scrapped and I didn’t fully revert the change.
Contributor
There was a problem hiding this comment.
It may be ok, it just requires the IDs to be byte arrays that use a valid character set so they can go back and forth from string encoding without being lossy. Right now that should always be the case in practice, it just may be problematic if/when we start using short for internal representations of adapter ID
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.