Travis is failing the tests for the jp2 files.

Running mil.nga.giat.geowave.format.sentinel2.RasterIngestRunnerTest
Downloading scene 'S2A_MSIL1C_20180104T110431_N0206_R094_T30TXN_20180104T130839'
Wait please... 
Downloading File 'http://sentinel-s2-l1c.s3-website.eu-central-1.amazonaws.com/tiles/30/T/XN/2018/1/4/0/productInfo.json' (1 KB) -> ok: (1 KB)
Downloading File 'http://sentinel-s2-l1c.s3-website.eu-central-1.amazonaws.com/tiles/30/T/XN/2018/1/4/0/preview.jpg' (12 KB) -> ok: (146 KB)
Downloading File 'http://sentinel-s2-l1c.s3-website.eu-central-1.amazonaws.com/tiles/30/T/XN/2018/1/4/0/B04.jp2' (16 KB) -> ok: (113 MB)
Apr 25, 2018 8:06:56 AM it.geosolutions.imageio.gdalframework.GDALUtilities loadGDAL
INFO: GDAL Native Library loaded (version: 1.9.2)
terminate called after throwing an instance of 'std::length_error'
  what():  basic_string::_S_create
Aborted (core dumped)

perhaps we need to add GDAL_DRIVER_PATH as an environment variable to surefire, similar to what we add to failsafe here: https://github.com/locationtech/geowave/blob/master/test/pom.xml#L412-L413

we also cache large files in travis so we don't need to reach out and download it every run, for example with landsat8: https://github.com/locationtech/geowave/blob/master/.travis.yml#L30

Thanks @rfecher, but I have a problem, the module is using the native ECW plugin for GDAL (Using the gdal_ECW_JP2ECW.dll in Windows) that I think it doesn't exist in the GDAL-1.9.2 zip redist downloaded from here, I have to study about this issue.

ahh - sorry, I didn't dig in enough to realize that problem

it does sound like it could be troublesome, I'll try to find some time to investigate more as well. Unfortunately in the end, we can't include tests that can't pass travis-ci so we'll have to think of some alternative.

Thanks a lot! I don't know how to resolve this (my apologies for the inconvenience) without copy my own gdal_ECW_JP2ECW file (dll or so). I don't have found any public repository from where to download them.

This is my problematic line :-(

After several attempts, I am not be able to test if ECWJP2 plugin is properly setup in order to use or to notify to user that AWS provider is not available. It works in Windows, but I get a not-catchable native error in Travis that stops the checks.

Update:
Could this to be the cause?

I will try to take a closer look when I have a chance, but in the meantime don't hesitate to keep giving it a shot. I looked around and so there may be some instability with the ECW decoding through java bindings such as the issue you highlighted in your update. Is this a public repo where it could be used for travis CI? I carefully read the EULA, and we should be ok to use it in travis CI's testing within the context of an open source project packaging the GDAL ECW decoder purely for testing a community contribution (not for profit).

Thanks @rfecher !, I am reviewing this module from SNAP - ESA's SentiNel Application Platform (https://github.com/senbox-org/s2tbx/tree/master/lib-gdal).

It provides GDAL 2.1.3 for Windows including native JP2ECW plugin, and GDAL 2.2.0 for Linux.

I think this module is used by ESA Tools to read JP2 Files.

UPDATE:
May be this module has the key, It reads the content of Sentinel2 products

the module you linked looks promising, but one caveat that we will have to be careful with, we can't add it as a direct dependency (I think we can use it with maven "test" scope though which may work out ok)
...
the license is GPL, which is incompatible with EPL (Eclipse Product License) or Apache 2.0
to be IP-compliant with the Eclipse Foundation's standards we can use it in the sense that it "works with" our software, but we cannot "depend on" it. I believe running tests only with it included as a maven module but not including it anywhere else, will be sufficient for the "works with" definition.

Hi @rfecher, I have fixed the sentinel2 module in Travis (Linux with GDAL 1.9.2). I found several options, but I think I have chosen the least intrusive one in order to modify the global behavior as minimum as possible.

I was testing:

• Change the GDAL 1.9.2 redist used to test with a fixed version of the JP2ECW core in Linux platforms. It requires to download it from an unknown public resource (this doesn't work and the ESA module has GPL license as you said).
• Clear the NCS_USER_PREFS environment variable for testing to avoid the JP2ECW plugin loading.

I have chosen the last one.

Where did you download the test JP2 file thats included in this PR? Also, to pass IP scrutiny, we need to make sure any data included in the baseline comes with an appropriately open license. If we're not sure about the license, it ends up being better to have the software download it as part of the test rather than include it in the baseline (for this we don't have to worry as much about the licensing because we are not distributing the data).

I downloaded it from AWS (I think is the "T30TXN-2017-10-16" scene), I was searching a very little image. But I could confirm it if you want.

Thanks @rfecher for reviewing and merging!

of course, sorry for the delays

You are welcome!