Merged
Conversation
Signed-off-by: Srinivas Varala <srinivas.varala@gmail.com>
Signed-off-by: Srinivas Varala <srinivas.varala@gmail.com>
Signed-off-by: Srinivas Varala <srinivas.varala@gmail.com>
Signed-off-by: Srinivas Varala <srinivas.varala@gmail.com>
Signed-off-by: Srinivas Varala <srinivas.varala@gmail.com>
rfecher
reviewed
Feb 27, 2018
| final PrimaryIndex index ) | ||
| throws Exception { | ||
| final PrimaryIndex index = new SpatialIndexBuilder().createIndex(); | ||
| // final PrimaryIndex index = new SpatialIndexBuilder().createIndex(); |
rfecher
reviewed
Feb 27, 2018
| for (final IntermediateSplitInfo split : splits) { | ||
| retVal.add(split.toFinalSplit()); | ||
| } | ||
|
|
rfecher
reviewed
Feb 27, 2018
| Envelope mapExtent; | ||
|
|
||
| CoordinateReferenceSystem crs = null; | ||
| if (crsCode.equals(GeometryUtils.DEFAULT_CRS_STR)) { |
Contributor
There was a problem hiding this comment.
can we check for null || empty || crsCode equals default
rfecher
reviewed
Feb 27, 2018
| @Parameter(names = "--cqlFilter", description = "An optional CQL filter applied to the input data") | ||
| private String cqlFilter; | ||
|
|
||
| @Parameter(names = "--outputIndex", description = "An optional index for output datastore. Only spatial index is supported") |
Contributor
There was a problem hiding this comment.
simple wording suggestion: Only spatial index type is supported.
rfecher
reviewed
Feb 27, 2018
| public void init( | ||
| PrimaryIndex... indices ) { | ||
| // TODO Auto-generated method stub | ||
| String indexCrsCode = null; |
Contributor
There was a problem hiding this comment.
is this set of code necessary at all? I read it as assigned a local variable that is unused and the index is coming into fitToIndex so this currently seems unnecessary.
rfecher
reviewed
Feb 27, 2018
| .getConstraints( | ||
| filter, | ||
| GeoWaveGTRasterFormat.DEFAULT_CRS, | ||
| // GeoWaveGTRasterFormat.DEFAULT_CRS, |
rfecher
reviewed
Feb 27, 2018
| PrimaryIndex[] indices = adapterMapping.getIndices(geowaveIndexStore); | ||
|
|
||
| if (indices != null && indices.length > 0) { | ||
| if (indices[0].getIndexModel() instanceof CustomCrsIndexModel) { |
Contributor
There was a problem hiding this comment.
this section could probably use GeometryUtils.getCRS(index) to reuse some code
rfecher
reviewed
Feb 27, 2018
|
|
||
| // for first iteration | ||
| if (indexCrs == null) { | ||
| if (primaryindx.getIndexModel() instanceof CustomCrsIndexModel) { |
Contributor
There was a problem hiding this comment.
this whole method could probably be in geometryutils, and this section could reuse the GeometryUtils.getCRS(index) method
rfecher
reviewed
Feb 27, 2018
| public static final PrimaryIndex DEFAULT_SPATIAL_TEMPORAL_INDEX = new SpatialTemporalDimensionalityTypeProvider() | ||
| .createPrimaryIndex(new SpatialTemporalOptions()); | ||
| public static String CUSTOM_CRSCODE = "EPSG:3070"; | ||
| // public static String CUSTOM_CRSCODE = "EPSG:3070"; |
rfecher
reviewed
Feb 27, 2018
| "geotools-vector", | ||
| 1); | ||
|
|
||
| // File configFile = File.createTempFile( |
rfecher
reviewed
Feb 27, 2018
| resizeTileSizeCoverageName); | ||
| command.getOptions().setIndexId( | ||
| TestUtils.createCustomCRSPrimaryIndex().getId().getString() | ||
| // TestUtils.DEFAULT_SPATIAL_INDEX.getId().toString() |
Signed-off-by: Srinivas Varala <srinivas.varala@gmail.com>
… raster-custom-projection
rfecher
requested changes
Feb 28, 2018
| geotiffFile); | ||
| } | ||
|
|
||
| /* |
| } | ||
| catch (FactoryException e) { | ||
| // TODO Auto-generated catch block | ||
| e.printStackTrace(); |
Contributor
There was a problem hiding this comment.
this should be logged, and remove TODO
Signed-off-by: Srinivas Varala <srinivas.varala@gmail.com>
rfecher
approved these changes
Mar 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.