Skip to content

Provided status endpoint for REST operations and return data in JSON format#1260

Merged
rfecher merged 1 commit intomasterfrom
beckerr_rest_status_endpoints
Dec 4, 2017
Merged

Provided status endpoint for REST operations and return data in JSON format#1260
rfecher merged 1 commit intomasterfrom
beckerr_rest_status_endpoints

Conversation

@richard3d
Copy link
Copy Markdown
Contributor

This work includes updates to ServiceEnabledCommand (and classes that derive from it) to provide a hint to services on whether the operation should be run sync/async.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 2, 2017

Coverage Status

Coverage decreased (-0.08%) to 49.248% when pulling abcf4be on beckerr_rest_status_endpoints into 602f4f2 on master.

3 similar comments
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 2, 2017

Coverage Status

Coverage decreased (-0.08%) to 49.248% when pulling abcf4be on beckerr_rest_status_endpoints into 602f4f2 on master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 49.248% when pulling abcf4be on beckerr_rest_status_endpoints into 602f4f2 on master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 49.248% when pulling abcf4be on beckerr_rest_status_endpoints into 602f4f2 on master.

Copy link
Copy Markdown
Contributor

@rfecher rfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its a really quick change, but very appropriate

}

@Override
public boolean runAsync() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be async

@richard3d richard3d force-pushed the beckerr_rest_status_endpoints branch from abcf4be to 22ef374 Compare December 4, 2017 16:49
@rfecher rfecher merged commit d332463 into master Dec 4, 2017
@rfecher rfecher deleted the beckerr_rest_status_endpoints branch December 4, 2017 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants