Conversation
rfecher
requested changes
Nov 15, 2017
|
|
||
| // HP Fortify "Null Dereference" false positive | ||
| // Null checking is done in the next line | ||
| String s3EndpointUrl = configProperties.getProperty(ConfigAWSCommand.AWS_S3_ENDPOINT_URL); |
Contributor
There was a problem hiding this comment.
its talking about configProperties, this one's a true-positive (line 151 configProperties is set to null and is only set to non-null within a conditional)
|
|
||
| // HP Fortify "Portability Flaw" false positive | ||
| // This is purposefully kept dynamic so help solve portability problems. | ||
| final ClientConfiguration clientConfig = new ClientConfiguration() |
Contributor
There was a problem hiding this comment.
lets just delete toLowerCase on line 65 and change equals on line 73 to equalsIgnoreCase()
97e7b4f to
64e0629
Compare
64e0629 to
7790b2a
Compare
rfecher
approved these changes
Nov 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.