Conversation
2 similar comments
|
|
||
| private final AccumuloSplitsProvider splitsProvider = new AccumuloSplitsProvider(); | ||
|
|
||
| private final HashMap<ByteArrayId, Integer> dupCountMap = new HashMap<>(); |
There was a problem hiding this comment.
these maps cannot be used per datastore - delete() should be able to be called concurrently with the same instance of a datastore (no shared state).
There was a problem hiding this comment.
OK. Can we discuss?
|
|
||
| protected boolean useWholeRowIterator() { | ||
| return (visibilityCounts == null) || visibilityCounts.isAnyEntryDifferingFieldVisiblity(); | ||
| return false;// (visibilityCounts == null) || |
| <artifactId>geowave-datastore-hbase</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <!-- |
There was a problem hiding this comment.
probably cleaner to remove commented out block here
| @@ -0,0 +1,92 @@ | |||
| package mil.nga.giat.geowave.cli.debug; | |||
There was a problem hiding this comment.
is this duplicative of vector CQLDelete? Is there a reason to have this separately?
There was a problem hiding this comment.
No. This can go away now that 'vector cqldelete' is working
|
|
||
| public static Range byteArrayRangeToAccumuloRange( | ||
| final ByteArrayRange byteArrayRange ) { | ||
| if (byteArrayRange.isSingleValue()) { |
There was a problem hiding this comment.
out of curiousity, did this relate to a bug encountered? ie. how did you come across this change?
| final DistributableQuery query = TestUtils.resourceToQuery(savedFilterResource); | ||
| CloseableIterator<?> actualResults; | ||
|
|
||
| actualResults = geowaveStore.query( |
There was a problem hiding this comment.
to test dupe bookkeeping, use a null query to count all the results as well as this to count how many should be deleted...after delete query all the results again and make sure it equals initialAllResults - expectedFeaturesDeleted
|
@rfecher - Hold off on the PR - i made some improvements to the ITs, and i'll need to squash again after these last three commits I think |
|
@rfecher - I'm done w/ my edits, but we still have those two that weren't mine. Need to decide why those are there and what (if anything) we should do about them. |
|
@rfecher - Also, do we want to squash ALL the 1027 commits once the edits are complete? |
5 similar comments
54ab4fb to
1ea786d
Compare
No description provided.