Skip to content

Enabled Authorization Provider for the raster data adapter plugin#1066

Merged
rfecher merged 1 commit intomasterfrom
GEOWAVE-1063
Apr 25, 2017
Merged

Enabled Authorization Provider for the raster data adapter plugin#1066
rfecher merged 1 commit intomasterfrom
GEOWAVE-1063

Conversation

@jwomeara
Copy link
Copy Markdown
Contributor

@jwomeara jwomeara commented Apr 7, 2017

Looks good to me!

@jwomeara
Copy link
Copy Markdown
Contributor Author

I'm not sure why this build is failing. The docs are failing to build apparently because it can't find my geowave-adapter-auth artifact, but it built just fine in my original branch... I tried building locally and that worked for me as well. Any suggestions?

@jwomeara
Copy link
Copy Markdown
Contributor Author

Good to go?

@rfecher
Copy link
Copy Markdown
Contributor

rfecher commented Apr 10, 2017

the PR build was cancelled...restarting

@jwomeara
Copy link
Copy Markdown
Contributor Author

What? The pull request build completed: https://travis-ci.org/ngageoint/geowave/builds/220623394

It's the branch build which was canceled.

@rfecher
Copy link
Copy Markdown
Contributor

rfecher commented Apr 10, 2017

yeah, ok the branch was cancelled then, why are the dependencies marked provided again?

@jwomeara
Copy link
Copy Markdown
Contributor Author

Because they conflict with the versions that are already included within geowave-adapter-vector and geowave-adapter-raster. They are pulled in as transitive dependencies of geoserver. We could go through and use dependency management to avoid that issue, but I figured it would be easier to just let geoserver decide which version we use.

@rfecher
Copy link
Copy Markdown
Contributor

rfecher commented Apr 10, 2017

I'm confused because they look to match the versions from geoserver 2.10.0

Also, <scope>${geotools.scope}</scope> would be better I think, and yeah, using the dependencymanagement in the parent pom would also be better. The reason for geotools.scope is that these dependencies are packaged for other uses than just geoserver, and we want to make sure we don't get classnotfoundexceptions other places

@jwomeara
Copy link
Copy Markdown
Contributor Author

The conflict occurs when you build with cloudera as it includes a different version of jackson-mapper-asl. I'll push out another update.

@jwomeara jwomeara force-pushed the GEOWAVE-1063 branch 2 times, most recently from b3d5d2e to 83f11a0 Compare April 11, 2017 00:29
Comment thread extensions/adapters/auth/pom.xml Outdated
<groupId>org.springframework.security</groupId>
<artifactId>spring-security-core</artifactId>
<version>4.0.4.RELEASE</version>
<scope>provided</scope>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why provided?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You aren't looking at the latest commit. Try this: 83f11a0#diff-c3f3a0b58ea56b7b1532923859181c72R15

@rfecher rfecher merged commit 86b324b into master Apr 25, 2017
@rfecher rfecher deleted the GEOWAVE-1063 branch April 25, 2017 12:50
@jwomeara
Copy link
Copy Markdown
Contributor Author

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants