Skip to content

Error in log file re: missing zookeeper server params #439

@chrisbennight

Description

@chrisbennight

This looks to me to be an issue with the logic on validating if a plugin can process data (at least in the integration test context)

Things looked okay here:
https://travis-ci.org/ngageoint/geowave/jobs/68079678
(Merge #434 - Asciidoc changes )

Next merge on master was this:
https://travis-ci.org/ngageoint/geowave/jobs/68079920
(Merge #430 - Content Data Store )

If you search for "missing" in the second job
(example: https://travis-ci.org/ngageoint/geowave/jobs/68079920#L3345 )
you will note we have lots of errors of the form:

27 Jun 15:58:16 ERROR [plugin.GeoWaveGTDataStoreFactory] - Invalid parameters
mil.nga.giat.geowave.adapter.vector.plugin.GeoWavePluginException: Accumulo Plugin: Missing zookeeper servers param
    at mil.nga.giat.geowave.adapter.vector.plugin.GeoWavePluginConfig.<init>(GeoWavePluginConfig.java:150)
    at mil.nga.giat.geowave.adapter.vector.plugin.GeoWaveGTDataStoreFactory.canProcess(GeoWaveGTDataStoreFactory.java:132)
    at org.geotools.data.DataAccessFinder.getDataStore(DataAccessFinder.java:109)
    at org.geotools.data.DataStoreFinder.getDataStore(DataStoreFinder.java:89)
    at mil.nga.giat.geowave.format.geotools.vector.GeoToolsVectorDataStoreIngestPlugin.supportsFile(GeoToolsVectorDataStoreIngestPlugin.java:83)
    at mil.nga.giat.geowave.core.ingest.local.LocalPluginFileVisitor$PluginVisitor.supportsFile(LocalPluginFileVisitor.java:74)
(...)

Specifically It looks like this line https://github.com/ngageoint/geowave/blob/master/extensions/adapters/vector/src/main/java/mil/nga/giat/geowave/adapter/vector/plugin/GeoWaveGTDataStoreFactory.java#L132
is responsible.

in the integration tests this map only has one value - "url":"file:/path/to/hail.shp"

Doesn't look like it will break general functionality (Seems to be an issue with that code path only passing url parameter and not the rest) - but still a gotcha. Might be a working as intended (though don't think so) - but in that case we at a minimum need a different log/error message.

@rfecher @dcy2003

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions