fix signal handling in localstack-supervisor#8007
Merged
Conversation
ed8d9dc to
df56977
Compare
alexrashed
approved these changes
Mar 29, 2023
Member
alexrashed
left a comment
There was a problem hiding this comment.
Wow, great catch! Looks good to me! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dfangl noticed that SIGINT is not terminating localstack correctly in docker. this PR makes sure that SIGINT to the supervisor is translated into a SIGTERM to localstack. we tried to forward SIGINT but couldn't quite figure it out. left a todo in there for future daniel and thomas :P
We also now use SIGUSR1 instead of SIGHUP to restart LS, to avoid restarting when the shell is closed (it will now just be ignored. We could start terminating, we can discuss if this is expected).
/cc @alexrashed