Conversation
We log at warning level if multiple gateway addresses are passed, but we haven't set up the logger yet 🤦
When the port is missing, we were getting an error
This means that the CLI starts the server and binds to the correct ports as configured by GATEWAY_LISTEN
simonrw
commented
Mar 23, 2023
| # TODO: this will likely become the default and may get removed in the future | ||
| FORWARD_EDGE_INMEM = True | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
This section is moved further up the file so we have access to the logger by the time we parse GATEWAY_LISTEN
thrau
approved these changes
Mar 24, 2023
Member
thrau
left a comment
There was a problem hiding this comment.
LGTM! thanks for jumping on this.
in a next step, maybe we could use HostAndPort to manage optional ports and consolidate with parse_hostname_and_ip
Contributor
Author
|
Thanks @thrau for the suggestion. I agree there is duplication in there that would be nice to remove. |
This was referenced Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some parsing bugs with handling
LOCALSTACK_HOSTandGATEWAY_LISTEN. This PR fixes those issues.and when supplying multiple
GATEWAY_LISTENvalues:Also ensure the CLI binds the docker port as prescribed by
GATEWAY_LOCAL