Skip to content

Add back s3 v2 provider alias#7943

Merged
dominikschubert merged 1 commit intomasterfrom
s3-v2-provider-alias
Mar 25, 2023
Merged

Add back s3 v2 provider alias#7943
dominikschubert merged 1 commit intomasterfrom
s3-v2-provider-alias

Conversation

@dominikschubert
Copy link
Member

The intent here is to avoid bricking environments for users that are still setting PROVIDER_OVERRIDE_S3=v2.
Default, v2 and asf are then equivalent and will all start the v2 s3 provider.

@dominikschubert dominikschubert requested a review from bentsku March 23, 2023 19:54
@dominikschubert dominikschubert self-assigned this Mar 23, 2023
@dominikschubert dominikschubert requested a review from thrau March 23, 2023 19:54
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bentsku bentsku force-pushed the s3-v2-provider-alias branch from ee82405 to a5e5644 Compare March 24, 2023 22:33
@coveralls
Copy link

Coverage Status

Coverage: 81.763% (+0.02%) from 81.746% when pulling a5e5644 on s3-v2-provider-alias into 7ae6048 on master.

@dominikschubert dominikschubert merged commit 0747559 into master Mar 25, 2023
@dominikschubert dominikschubert deleted the s3-v2-provider-alias branch March 25, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants