Skip to content

Add cache for common functions#7942

Merged
dfangl merged 3 commits intomasterfrom
cache-lambda-common
Mar 24, 2023
Merged

Add cache for common functions#7942
dfangl merged 3 commits intomasterfrom
cache-lambda-common

Conversation

@dfangl
Copy link
Member

@dfangl dfangl commented Mar 23, 2023

Adds a cache to the common functions to avoid building them every build.
Uses a file with a list of all hashes of hash-key-files as hash-key (so hashing the file full of hashes), as CircleCI does not support hashing multiple files (via a glob or something) sadly.
Reduces amd64 build time by about 10 minutes.

@dfangl dfangl requested review from alexrashed and thrau as code owners March 23, 2023 17:39
@dfangl dfangl force-pushed the cache-lambda-common branch from 8210329 to c3ff036 Compare March 23, 2023 17:39
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! This will speed up the new pipeline by quite a few minutes for each run! 🚀

@dfangl dfangl force-pushed the cache-lambda-common branch from ab10ce8 to c532da6 Compare March 23, 2023 21:15
@dfangl dfangl force-pushed the cache-lambda-common branch from c532da6 to 150fa6d Compare March 24, 2023 08:46
@coveralls
Copy link

Coverage Status

Coverage: 81.806% (-0.006%) from 81.812% when pulling 150fa6d on cache-lambda-common into a7af959 on master.

@dfangl dfangl merged commit b5427bb into master Mar 24, 2023
@dfangl dfangl deleted the cache-lambda-common branch March 24, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants