Dynamically determine ports check Docker image to avoid duplicate download#7931
Merged
Dynamically determine ports check Docker image to avoid duplicate download#7931
Conversation
thrau
reviewed
Mar 23, 2023
Member
thrau
left a comment
There was a problem hiding this comment.
great catch! i didn't know we were doing that at all :-)
just one comment about a simplification to get rid of _State
877fb38 to
684ee7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamically determine ports check Docker image to avoid duplicate image download.
Currently, the default image we're using for the port availability checks is
localstack/localstack(unless configured manually viaPORTS_CHECK_DOCKER_IMAGE). For Pro users (localstack/localstack-pro), this means that potentially an additional image would be downloaded at runtime.This hasn't been an issue so far (as the images were aliases), but is now becoming relevant for the upcoming image split in v2.