fix validation in test for put-subscription-filter with lambda#7894
Merged
fix validation in test for put-subscription-filter with lambda#7894
Conversation
dominikschubert
approved these changes
Mar 17, 2023
| filtered_events.append(log_event) | ||
| assert len(filtered_events) == 2 | ||
|
|
||
| filtered_events.sort(key=lambda k: k.get("message")) |
Member
There was a problem hiding this comment.
nit: could be replaced with a sorting transformer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While adding persistence test for logs, I found that the validation for this test is actually misleading, as it didn't check the lambda-logs which should ensure the actual invocation