Skip to content

fix scheduler start/stop for persistence#7885

Merged
giograno merged 1 commit intomasterfrom
cloudwatch-persistence
Mar 17, 2023
Merged

fix scheduler start/stop for persistence#7885
giograno merged 1 commit intomasterfrom
cloudwatch-persistence

Conversation

@steffyP
Copy link
Member

@steffyP steffyP commented Mar 16, 2023

CloudWatch is using a scheduler, that should check if an alarm state should change periodically.

  • The scheduler should be restarted and check all existing metric-alarms for the on_*_load scenario.
  • The scheduler should also be restarted for the on_*_reset scenario

@steffyP steffyP requested a review from giograno March 16, 2023 16:53
@steffyP steffyP temporarily deployed to localstack-ext-tests March 16, 2023 16:54 — with GitHub Actions Inactive
@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 38m 51s ⏱️ - 4m 12s
1 796 tests ±0  1 414 ✔️ ±0  382 💤 ±0  0 ±0 
2 514 runs  ±0  1 780 ✔️ ±0  734 💤 ±0  0 ±0 

Results for commit 43d4742. ± Comparison against base commit 77aab87.

Copy link
Member

@giograno giograno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start/stop logic looks good 👍

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 43d4742 on cloudwatch-persistence into ** on master**.

@giograno giograno merged commit 5930135 into master Mar 17, 2023
@giograno giograno deleted the cloudwatch-persistence branch March 17, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants