Skip to content

DynamoDB: Fix unprocessed item not added to response#7879

Merged
viren-nadkarni merged 1 commit intomasterfrom
dynamodb-unprocessed
Mar 16, 2023
Merged

DynamoDB: Fix unprocessed item not added to response#7879
viren-nadkarni merged 1 commit intomasterfrom
dynamodb-unprocessed

Conversation

@viren-nadkarni
Copy link
Member

Closes #7597

Supersedes #7598

in dynamodb batchWriteResponse
@viren-nadkarni viren-nadkarni self-assigned this Mar 15, 2023
@viren-nadkarni viren-nadkarni temporarily deployed to localstack-ext-tests March 15, 2023 13:16 — with GitHub Actions Inactive
@localstack-bot
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@viren-nadkarni viren-nadkarni requested a review from giograno March 15, 2023 13:21
@viren-nadkarni viren-nadkarni marked this pull request as ready for review March 15, 2023 13:21
@github-actions
Copy link

LocalStack integration with Pro

       2 files   -     1         2 suites   - 1   1h 32m 57s ⏱️ - 7m 8s
1 802 tests ±    0  1 417 ✔️  -     3  385 💤 +    3  0 ±0 
2 157 runs   - 371  1 592 ✔️  - 202  565 💤  - 169  0 ±0 

Results for commit 05df0c2. ± Comparison against base commit 080d53e.

@coveralls
Copy link

Coverage Status

Coverage: 85.122% (+0.02%) from 85.103% when pulling 05df0c2 on dynamodb-unprocessed into 080d53e on master.

@Yliu12
Copy link
Contributor

Yliu12 commented Mar 15, 2023

Thank you @viren-nadkarni!

@viren-nadkarni viren-nadkarni merged commit efeb812 into master Mar 16, 2023
@viren-nadkarni viren-nadkarni deleted the dynamodb-unprocessed branch March 16, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS dynamodb.BatchWriteItem => 500 (InternalError) when DYNAMODB_ERROR_PROBABILITY set.

5 participants