Add v1 provider aliases for legacy providers#7875
Merged
Conversation
thrau
approved these changes
Mar 15, 2023
Member
thrau
left a comment
There was a problem hiding this comment.
great idea! we'll probably see this pattern a few more times moving forward, so maybe makes sense to introduce this as first class citizen into the provider plugins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we currently have been advertising the newer provider implementations as
v2, users might try to "revert" to the legacy provider by setting thePROVIDER_OVERRIDE_<svc>variable tov1. Unfortunately this will currently fail since they need to remove the variable completely.This PR now introduces v1 aliases for the legacy (currently still default) providers with a
v2provider, i.e.lambda,s3andstepfunctionscc @bentsku @dfangl