ignore scheduled rules when processing put_events#7848
Merged
dominikschubert merged 1 commit intomasterfrom Mar 13, 2023
Merged
ignore scheduled rules when processing put_events#7848dominikschubert merged 1 commit intomasterfrom
dominikschubert merged 1 commit intomasterfrom
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #7847
Since scheduled events don't have a pattern and it defaults to a "{}" pattern, they were always unintentionally triggering the targets of the scheduled event rule when calling
put_events(which should only consider pattern-based event rules).To fix this we now ignore any rules that have a
scheduled_expressionset (which would otherwise default to None).