Conversation
bentsku
left a comment
There was a problem hiding this comment.
Hi @deepak2431 and thanks a lot for your contribution!
Would it be possible to add an integration test in tests/integration/test_kms.py?
Here's our documentation about contributing: https://docs.localstack.cloud/contributing/contributing/ and writing integration tests: https://docs.localstack.cloud/contributing/integration-tests/
Thank you!
Thanks for the review @bentsku. |
|
@bentsku I have added the integration test. |
bentsku
left a comment
There was a problem hiding this comment.
@bentsku I have added the integration test.
Awesome, this is exactly what we needed, thanks a lot for taking the time to write this test!
It's all good to go for me, I'll merge. 👍 congratulations for your first contribution!
This PR is for the fix of issue #7494
Initially, there was no validation on alias names done to create an alias. I have added the Alias name validation which would raise a ValidationException if the given alias name doesn't start with "alias/"
@bentsku You can review this.