Merged
Conversation
giograno
approved these changes
Mar 9, 2023
| return f"http://{LOCALHOST}:{server.port}" | ||
|
|
||
| @staticmethod | ||
| def get_store(account_id: str, region_name: str) -> KinesisStore: |
Member
There was a problem hiding this comment.
Had a quick look at the kinesis stores. Are we using them somewhere?
Member
Author
There was a problem hiding this comment.
good question, i didn't actually look into it. but may be useful to keep it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors our Kinesis provider to use the new state lifecycle hooks.
KinesisServerManageron_before_state_load: before a state load, we only need to shut down already running kinesis backends. the kinesis backends are re-started lazily the next time they are requested.on_before_state_reseton_before_stopjust shuts them downtested manually with the new persistence plugin using localstack-ext