refactor SNS store to facilitate lookups#7803
Merged
Conversation
thrau
approved these changes
Mar 4, 2023
Contributor
Author
Yes, looks like a lot of tests are failing 😅 I changed some logic and think I went a bit too much on some checks, especially if subscription is confirmed, will add some tests and validate this with AWS. |
Member
|
@bentsku are we merging this? |
Contributor
Author
|
@thrau Yes, I think so? If we're breaking persistence, now is the time to go. We can also wait a bit to be closer to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we're currently working on persistence, I'd like to refactor the SNS store to facilitate lookup and have its data structures more aligned with how we are using them in the provider and to how AWS stores them.
Added some validations where I had questions on how AWS would behave.