Skip to content

add cwd parameter to ShellCommandThread#7800

Merged
thrau merged 1 commit intomasterfrom
fix-shell-command-thread
Mar 5, 2023
Merged

add cwd parameter to ShellCommandThread#7800
thrau merged 1 commit intomasterfrom
fix-shell-command-thread

Conversation

@thrau
Copy link
Member

@thrau thrau commented Mar 3, 2023

This PR passes the cwd argument through the ShellCommandThread to the underlying popen command.

@thrau thrau temporarily deployed to localstack-ext-tests March 3, 2023 22:53 — with GitHub Actions Inactive
@thrau thrau requested a review from whummer March 3, 2023 23:33
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

LocalStack integration with Pro

       3 files  +    1         3 suites  +1   1h 35m 3s ⏱️ +50s
1 778 tests ±    0  1 399 ✔️ +    3  379 💤  -     3  0 ±0 
2 504 runs  +371  1 775 ✔️ +203  729 💤 +168  0 ±0 

Results for commit e057f85. ± Comparison against base commit 712c40b.

Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @thrau ! 👍

@thrau thrau merged commit 881018e into master Mar 5, 2023
@thrau thrau deleted the fix-shell-command-thread branch March 5, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants