add an exception handler to serialize werkzeug HTTPException#7790
Merged
add an exception handler to serialize werkzeug HTTPException#7790
Conversation
alexrashed
approved these changes
Mar 15, 2023
Member
alexrashed
left a comment
There was a problem hiding this comment.
The implementation is looking good, and it will become quite useful once we can move the service name parser down the handler chain! 🚀
I only have one comment concerning a unit test, but nothing blocking a merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds logic to our fallback exception handler to render werkzeug HTTPException instances.
Previously, calling internal resources (or custom routes that would not be detected as s3 routes) with wrong methods would output:
{ "error": "Unexpected exception", "message": "405 Method Not Allowed: The method is not allowed for the requested URL.", "type": "MethodNotAllowed" }because it interprets the
MethodNotAllowedexception as unexpected exception. with this new logic that generalize capturing of werkzeug HTTP exceptions, you can actually raise HTTP exceptions from within handlers, and get proper exception messages:{ "error": "Method Not Allowed", "message": "The method is not allowed for the requested URL." }Unfortunately, because the service name parser is still executed before the router handler, it doesn't work for most requests, since those are captured by the
ServiceExceptionSerializerwhich will serialize exceptions into s3 exceptions although the calls are not being made to s3. I added a bunch of tests & xfailed tests to document the expected behavior once that is remedied.