Conversation
macnev2013
requested changes
Mar 6, 2023
Contributor
macnev2013
left a comment
There was a problem hiding this comment.
Just have a minor doubt else LGTM ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #7782, we did not check the state of the KMS key when validating it.
Note that we need to set
S3_SKIP_KMS_KEY_VALIDATIONto0if we want this validation to be active, as we don't validate the existence of the KMS key per default, and only in the new provider (PROVIDER_OVERRIDE_S3=asf).This PR implements the validation of the state and a AWS validated snapshot test, as well as a fix for the key format when returned (keyArn instead of just the keyId).
fixes #7782