add persistence API integration for community services#7785
Merged
Conversation
dominikschubert
requested changes
Mar 4, 2023
Member
dominikschubert
left a comment
There was a problem hiding this comment.
Tiny issue with the create_cluster call, otherwise LGTM! 🚀
| LOG.info(f"Restoring domain {domain_name} in region {region}.") | ||
| try: | ||
| preferred_port = None | ||
| if config.OPENSEARCH_ENDPOINT_STRATEGY == "port": |
Member
There was a problem hiding this comment.
That's an interesting problem actually that might bite us in a few other places as well when a feature flag changes between different persistence-enabled runs 🤔
Member
Author
There was a problem hiding this comment.
indeed, already had to disable ports in rds snapshot tests https://github.com/localstack/localstack-ext/pull/1397/files#diff-9554b233d544d2d605d0a8067d419a1adc3ee3dfff6500f6524605217b7aaf65R7-R9
38ccc0a to
16691a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the persistence API to integrate community services into the persistence lifecycle. It's "basic" because it doesn't fully add restore functionality for every services.
accept_state_visitormethods to community services that have an asset directorySAVE_STRATEGYvariable used by the persistence plugin to the configcreate_domainmethod that were missing after the last ASF API update /cc @alexrashed