Conversation
7756af7 to
bd97e9a
Compare
6e58a00 to
08982ed
Compare
08982ed to
03d9fc3
Compare
03d9fc3 to
72abce8
Compare
simonrw
commented
Mar 8, 2023
baermat
requested changes
Mar 10, 2023
Member
baermat
left a comment
There was a problem hiding this comment.
Looks great! Small things remaining which can be fixed super quickly and then it's a go from my side 🎉
Contributor
Author
Thanks @baermat, I've implemented your changes |
baermat
approved these changes
Mar 13, 2023
This brings along #7870
We need to listen on the HTTP port rather than the HTTPS port
thrau
reviewed
Mar 17, 2023
Comment on lines
260
to
+264
| if config.SQS_PORT_EXTERNAL: | ||
| host_url = external_service_url("sqs") | ||
| host_definition = localstack_host( | ||
| use_hostname_external=True, custom_port=config.SQS_PORT_EXTERNAL | ||
| ) | ||
| host_url = f"{get_protocol()}://{host_definition.host_and_port()}" |
Member
There was a problem hiding this comment.
hey! i can see that SQS_PORT_EXTERNAL is still in the control path here although we decided to boot it. can we just remove this?
Contributor
Author
There was a problem hiding this comment.
This PR is just matching existing behaviour. I'll get rid of it in a follow up PR targeting the v2 branch once this is merged 👍
This was referenced Mar 17, 2023
dfangl
approved these changes
Mar 19, 2023
Member
dfangl
left a comment
There was a problem hiding this comment.
I mostly looked at the lambda parts, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR centralises the way we decide what hostname is returned when requested by the resource.
This PR contains tests that ensure the current behaviour. This is important as I consider changing the way the user configures returned names to be a backwards incompatible change. In a future PR when v2 will be released, we will update the new url function to be systematic, based on the new configuration.