Add lambda model and api updates by joe4dev · Pull Request #7762 · localstack/localstack

joe4dev · 2023-02-27T19:31:55Z

Contributions

Add support for runtime management controls at API level
Add support for SnapStart at API level
Add snapshot tests for SnapStart API
Update all lambda-related snapshot tests due to model updates (only for aws_validated tests)
Add platform flag to docker clients for build_image
Fix Lambda tests on ARM hosts. This enables running Lambda tests on ARM hosts.
Conditionally skip the concurrency tests if the AWS account has too low limits (improve error messages).

Limitations

Runtime management controls use a hard-coded sha256 value (8eeff65f6809a3ce81507fe733fe09b835899b99481ba22fd75b5a7338290ec1) instead of inspecting the Docker image.
Rust builds on ARM (tested on M1 MacBook Pro) are slow (~5 minutes) due to emulation. See Makefile for potential performance improvements.
The SnapStart tests are a little slow (~1-2min) against AWS

Breaking changes

This PR includes model changes in lambda and will break CloudPods for the new lambda provider

github-actions · 2023-02-27T20:37:34Z

LocalStack integration with Pro

      3 files ±0       3 suites ±0 1h 30m 49s ⏱️ - 1m 6s
1 773 tests +3 1 394 ✔️ ±0 379 💤 +3 0 ❌ ±0
2 499 runs +9 1 770 ✔️ ±0 729 💤 +9 0 ❌ ±0

Results for commit 25e9a0f. ± Comparison against base commit 8da70d7.

♻️ This comment has been updated with latest results.

joe4dev · 2023-02-28T12:13:50Z

tests/integration/cloudformation/resources/test_lambda.py

            "$..StartingPosition",
            "$..StateTransitionReason",
            "$..Topics",
+            # resource index mismatch due to SnapStart


That is an example where a new feature changes the indexing of snapshots because it matches a resource transformer. It is not ideal that we need to disable these snapshot verifications for the old provider due to an unrelated change.

Agreed. I'm generally not super happy with the state of the resource transformer. I've added this as a reference in our internal issue tracker for snapshots

Good to track that one. I think this might become a nasty source of flaky tests with automated test re-validation.

joe4dev · 2023-02-28T12:15:16Z

tests/integration/awslambda/test_lambda_api.py

+        "$..PolicyArn",
+        "$..Layers",
+        # mismatching resource index due to SnapStart
+        "$..Statement.Condition.ArnLike.'AWS:SourceArn'",


: break the JsonPath snapshot comparison and need to be enquoted using single quotes

Maybe we should add some validation for this to avoid errors like this. Was this fairly obvious when debugging?

The error was pretty specific (see below) but the stack trace wasn't particularly helpful in identifying the issue because the hook is executed after the test.
It could be nice to give some context when raising (e.g., which snapshot match or which verify skip path).

> raise JsonPathParserError('Parse error at %s:%s near token %s (%s)' % (t.lineno, t.col, t.value, t.type)) E jsonpath_ng.exceptions.JsonPathParserError: Parse error at 1:34 near token : (:) .venv/lib/python3.10/site-packages/jsonpath_ng/parser.py:81: JsonPathParserError

dominikschubert

LGTM! 🥳

Great that you uncovered a lot of hidden issues that we'll need to tackle at some point. (e.g. tests missing the validated marker, rust compilation, resource transformer)

localstack/services/awslambda/provider.py

tests/integration/awslambda/functions/common/endpointinjection/provided/Makefile

dominikschubert · 2023-03-01T07:58:37Z

tests/integration/awslambda/functions/common/introspection/go/Makefile

 	mkdir -p build
-	docker run --rm -v $$(pwd)/src:/app -v $$(pwd)/build:/out golang:latest@sha256:b850621230956a6d960d6d7cfaba6a8a2e8e245b230a928ef66aa0cfd065e229 /bin/bash -c "cd /app && GOOS=linux CGO_ENABLED=0 go build -trimpath -ldflags=-buildid= -o /out/main main.go && chown $$(id -u):$$(id -g) /out/main"
+	docker run --rm --platform $(DOCKER_PLATFORM) -v $$(pwd)/src:/app -v $$(pwd)/build:/out $(DOCKER_GOLANG_IMAGE) /bin/bash -c "cd /app && GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -trimpath -ldflags=-buildid= -o /out/main main.go && chown $$(id -u):$$(id -g) /out/main"
 	find ./build -exec touch -t 200001010100.00 {} \;


We could remove these since we're not actually checking size & hash of the zip files anymore

right, I added a TODO for build refactoring in test_lambda_common.py because the many identical Makefiles could be parametrized per runtime.

I wasn't sure initially whether the touch is for hashing or some caching ...

dominikschubert · 2023-03-01T08:00:14Z

tests/integration/awslambda/test_lambda.py

 else:
    pytestmark = pytest.mark.skip_snapshot_verify(
-        paths=["$..CodeSize", "$..SnapStart"],  # FIXME
+        paths=["$..CodeSize"],  # FIXME
    )


we can actually just remove codesize as well and add it to the "global" transformers above

Good catch 👍
I just removed it because CodeSize is already part of the lambda_api() transformer.

tests/integration/awslambda/test_lambda_api.py

dominikschubert · 2023-03-01T08:01:41Z

tests/integration/awslambda/test_lambda_api.py

+            "update_function_configuration_response_rev5..RuntimeVersionConfig.RuntimeVersionArn",
+            "get_function_response_rev6..RuntimeVersionConfig.RuntimeVersionArn",


Suggested change

"update_function_configuration_response_rev5..RuntimeVersionConfig.RuntimeVersionArn",

"get_function_response_rev6..RuntimeVersionConfig.RuntimeVersionArn",

"$..RuntimeVersionConfig.RuntimeVersionArn",

or was there a particular reason for only including those?

I still wanted the validation that the RuntimeVersionArn does not change between revisions and not ignore it completely for the entire test

dominikschubert · 2023-03-01T08:02:52Z

tests/integration/awslambda/test_lambda_api.py

+        "$..PolicyArn",
+        "$..Layers",
+        # mismatching resource index due to SnapStart
+        "$..Statement.Condition.ArnLike.'AWS:SourceArn'",


Maybe we should add some validation for this to avoid errors like this. Was this fairly obvious when debugging?

dominikschubert · 2023-03-01T08:06:48Z

tests/integration/cloudformation/resources/test_lambda.py

            "$..StartingPosition",
            "$..StateTransitionReason",
            "$..Topics",
+            # resource index mismatch due to SnapStart


Agreed. I'm generally not super happy with the state of the resource transformer. I've added this as a reference in our internal issue tracker for snapshots

Limitation: hardcoded runtime arn

`:` require escaping in JsonPaths

Addresses #7763

Is already part of the default transformer

joe4dev requested review from dfangl and dominikschubert as code owners February 27, 2023 19:31

joe4dev temporarily deployed to localstack-ext-tests February 27, 2023 19:32 — with GitHub Actions Inactive

joe4dev temporarily deployed to localstack-ext-tests February 27, 2023 22:27 — with GitHub Actions Inactive

joe4dev temporarily deployed to localstack-ext-tests February 28, 2023 09:16 — with GitHub Actions Inactive

joe4dev temporarily deployed to localstack-ext-tests February 28, 2023 10:59 — with GitHub Actions Inactive

joe4dev mentioned this pull request Feb 28, 2023

bug: lambda Add permission accepts non-compliant statement IDs #7763

Closed

1 task

joe4dev commented Feb 28, 2023

View reviewed changes

joe4dev force-pushed the add-lambda-model-and-api-updates branch from f3b3759 to b6b2a31 Compare February 28, 2023 15:46

joe4dev temporarily deployed to localstack-ext-tests February 28, 2023 15:46 — with GitHub Actions Inactive

dominikschubert approved these changes Mar 1, 2023

View reviewed changes

joe4dev added 17 commits March 1, 2023 10:12

Add lambda snap start model

2a0b749

Add SnapStart API tests

8d4e2b9

Update SnapStart optimization status correctly upon publishing version

1097611

Validate apply on parameter value

228262c

Handle SnapStart in function configuration update

bf145a0

Add runtime version config to lambda model

11a7fb1

Limitation: hardcoded runtime arn

Re-generate lambda snapshots

384ec8a

Fix account limit test failure and add skip check

99576d8

Fix parity for list of valid runtimes for layer

6d42061

Re-generate behavior test snapshots

3d394ed

Add comment about flaky snapshot generation

ae7f8ca

Fix lambda common builds for ARM

80c761a

Add platform support for build_image

a7da462

Re-generate lambda snapshots

7e21da3

Add missing aws_validated markers

6aeda6c

Skip snapshot verify for old provider

060fa3b

Fix skip verify for old provider

140d6c1

`:` require escaping in JsonPaths

joe4dev added 6 commits March 1, 2023 10:12

Fix skip verify for old provider

140d6c1

`:` require escaping in JsonPaths

Fix server-side validation update

c5aa571

Add lambda permission statement id validation

d329df0

Addresses #7763

Fix missing time unit in comment

44ffff2

Add refactor TODO comment for commons build

6d60f90

Remove redundant CodeSize verify skip

25e9a0f

Is already part of the default transformer

joe4dev force-pushed the add-lambda-model-and-api-updates branch from b6b2a31 to 25e9a0f Compare March 1, 2023 09:52

joe4dev temporarily deployed to localstack-ext-tests March 1, 2023 09:52 — with GitHub Actions Inactive

joe4dev merged commit ee27d16 into master Mar 1, 2023

joe4dev deleted the add-lambda-model-and-api-updates branch March 1, 2023 12:04

		"update_function_configuration_response_rev5..RuntimeVersionConfig.RuntimeVersionArn",
		"get_function_response_rev6..RuntimeVersionConfig.RuntimeVersionArn",

	"update_function_configuration_response_rev5..RuntimeVersionConfig.RuntimeVersionArn",
	"get_function_response_rev6..RuntimeVersionConfig.RuntimeVersionArn",
	"$..RuntimeVersionConfig.RuntimeVersionArn",

Uh oh!

Conversation

joe4dev commented Feb 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contributions

Limitations

Breaking changes

Uh oh!

github-actions bot commented Feb 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

LocalStack integration with Pro

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dominikschubert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joe4dev commented Feb 27, 2023 •

edited

Loading

github-actions bot commented Feb 27, 2023 •

edited

Loading