fix: api gateway headers request mapping#7729
Closed
amitassaraf wants to merge 16 commits intolocalstack:masterfrom
Closed
fix: api gateway headers request mapping#7729amitassaraf wants to merge 16 commits intolocalstack:masterfrom
amitassaraf wants to merge 16 commits intolocalstack:masterfrom
Conversation
calvernaz
reviewed
Feb 23, 2023
Contributor
calvernaz
left a comment
There was a problem hiding this comment.
Hi @amitassaraf, good timing! we are working on a generic implementation for the request parameters that will go out soon. So this code is being removed in a way. We'll keep this around for reference and close after we merge upstream
Member
|
Hi @amitassaraf and @calvernaz! |
Contributor
|
I'll go ahead and close the PR as this was superseded by #7580. Thanks again for your contribution, sorry this was being worked on simultaneously. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, API gateway blindly passes all headers from the request to the integration it connects with, the function I added does 2 things to mimic AWS functionality:
https://docs.aws.amazon.com/apigateway/latest/developerguide/request-response-data-mappings.html