Merged
Conversation
Motivated by a support case.
joe4dev
commented
Feb 22, 2023
joe4dev
commented
Feb 22, 2023
joe4dev
commented
Feb 22, 2023
whummer
approved these changes
Feb 24, 2023
Member
whummer
left a comment
There was a problem hiding this comment.
Awesome, great to see this covered with a snapshot @joe4dev @calvernaz ! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an rest api parity issue related to encoding paths in URL.
Actual behavior
Given the following invocation URL against a rest api (e.g., with
{proxy+}integration and a lambda function as backend):GET https://{restapi_id}.execute-api.{region}.amazonaws.com/{stage_name}/user/test%2Balias@gmail.com/plus/test+alias@gmail.com?email=test%2Balias@gmail.compath:"/{stage_name}/user/test+alias@gmail.com/plus/test+alias@gmail.com?email=test%2Balias@gmail.com"queryStringParameters.email:test+alias@gmail.comExpected behavior
The base
pathshould not decode URL encoded characters such as%2B => +and looks like this in AWS:/user/test%2Balias@gmail.com/plus/test+alias@gmail.comImplementation
Instead of relying on decoded
request.pathorrequest.full_pathfrom Werkzeug, we need to compose the invocationpathmanually consisting of a non-decoded base part and a decode params part.Questions
url_paramsbe None?stage_nameis omitted?