Skip to content

Don't require CAPABILITY_AUTO_EXPAND for change sets#7718

Merged
dominikschubert merged 1 commit intomasterfrom
fix_cfn-createchangeset-capabilities
Feb 21, 2023
Merged

Don't require CAPABILITY_AUTO_EXPAND for change sets#7718
dominikschubert merged 1 commit intomasterfrom
fix_cfn-createchangeset-capabilities

Conversation

@dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Feb 20, 2023 •
edited
Loading

Fixes a regression introduced in #7509

CFn Changesets, in contrast to Stacks, don't require the CAPABILITY_AUTO_EXPAND capability set when they include transformations/macros.

          NOTE:
                 This capacity doesn't apply  to  creating  change  sets,  and
                 specifying it when creating change sets has no effect. If you
                 want to create a stack from a stack  template  that  contains
                 macros and nested stacks, you must create or update the stack
                 directly from the template using the  CreateStack or   Updat-
                 eStack action, and specifying this capability.

TODOs:

  • add test covering change sets with transformation

@dominikschubert dominikschubert self-assigned this Feb 20, 2023
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests February 20, 2023 13:03 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Feb 20, 2023 •
edited
Loading

Coverage Status

Coverage: 85.013% (-0.003%) from 85.016% when pulling 0299eff on fix_cfn-createchangeset-capabilities into 4567080 on master.

@github-actions
Copy link

github-actions bot commented Feb 20, 2023 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 34m 34s ⏱️ +37s
1 732 tests +1  1 382 ✔️ ±0  350 💤 +1  0 ❌ ±0 
2 450 runs  +1  1 758 ✔️ ±0  692 💤 +1  0 ❌ ±0 

Results for commit ab15ca5. ± Comparison against base commit 133eda2.

♻️ This comment has been updated with latest results.

@dominikschubert dominikschubert marked this pull request as ready for review February 20, 2023 17:37
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests February 20, 2023 17:37 — with GitHub Actions Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests February 20, 2023 17:39 — with GitHub Actions Inactive
pinzon
pinzon approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@dominikschubert dominikschubert force-pushed the fix_cfn-createchangeset-capabilities branch from 0299eff to ab15ca5 Compare February 20, 2023 19:31
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests February 20, 2023 19:31 — with GitHub Actions Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests February 20, 2023 21:25 — with GitHub Actions Inactive
@dominikschubert dominikschubert merged commit 6d16650 into master Feb 21, 2023
@dominikschubert dominikschubert deleted the fix_cfn-createchangeset-capabilities branch February 21, 2023 06:04
@steffyP steffyP mentioned this pull request Feb 24, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon pinzon approved these changes

Assignees

@dominikschubert dominikschubert

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dominikschubert @coveralls @pinzon