Use token in GitHubReleaseInstaller for increased rate-limits#7716
Merged
dominikschubert merged 1 commit intomasterfrom Feb 20, 2023
Merged
Use token in GitHubReleaseInstaller for increased rate-limits#7716dominikschubert merged 1 commit intomasterfrom
dominikschubert merged 1 commit intomasterfrom
Conversation
thrau
approved these changes
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're often running into rate-limits in the
GitHubReleaseInstallerwhich calls the GitHub Rest API to get a list of artifacts for a given release. This is by default capped at 60 calls per hour (per IP) for unauthenticated calls and any further calls currently lead to pipeline failures.In CircleCI we're now using a custom secret (
GITHUB_API_TOKENwhich is a personal access token from @localstack-bot without any permissions). This increases the rate-limit to 5_000 calls per hour (independent of IP)In GitHub we're now using the intrinsic
GITHUB_TOKENsecret. This increases the rate-limit to 1_000 calls per hour(independent of IP). If we ever need a higher limit in GitHub we can also use the token, but as long as it's not necessary I feel using
GITHUB_TOKENis more reliable.Follow-up TODO: