Re-enable cli container lifecycle test#7702
Merged
Conversation
348730a to
0a05e68
Compare
0a05e68 to
a3b82b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables a Docker CLI test that depends on the not-immediately-updated
localstack/localstackimage from Dockerhub.Follow up from #7675
Background
tests.bootstrap.test_cli.TestCliContainerLifecycle.test_start_cli_within_containerdepends on the latest localstack/localstack image from DockerHub. The test could not pass because bumping the PyPidockerversion added an incompatibility. Specifically, aplatformflag required for fixing ARM compatibility in lambda.See internal demo