validate StartingPosition during CreateEventSourceMapping operation#7696
Merged
validate StartingPosition during CreateEventSourceMapping operation#7696
Conversation
7e922e2 to
934f3b5
Compare
1 task
ec1ae2a to
6377ff8
Compare
dominikschubert
requested changes
Feb 23, 2023
Member
dominikschubert
left a comment
There was a problem hiding this comment.
Mostly LGTM, but would be great if we could add the same validation in the update operation 🙏
Co-authored-by: Dominik Schubert <dominik.schubert91@gmail.com>
4ec34d6 to
fd9fd35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the CreateEventSourceMapping operation validate the StartingPosition parameter. Addresses #7548
Changes: