Conversation
Member
dominikschubert
left a comment
There was a problem hiding this comment.
Just looked over the part for which you tagged me (lambda flask refactoring). Seems innocent enough with the move 👍
I'll leave the rest for @thrau though to approve.
thrau
approved these changes
Feb 15, 2023
Member
thrau
left a comment
There was a problem hiding this comment.
looks great! thanks for untangling all this, will make it much easier to remove dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to decrease the coupling to our LocalStack Pro extensions.
It can only merged together with its companion PR.
The changes are separated in different commits:
edge.py. It will be started as a Pro plugin (infra start hook) instead./cc @dfangl
/cc @whummer
/cc @dominikschubert