Ignore dangling images in localstack update#7691
Merged
Conversation
LocalStack integration with Pro 1 files - 2 1 suites - 2 1h 34m 24s ⏱️ + 6m 9s For more details on these failures, see this check. Results for commit 1e083ba. ± Comparison against base commit 14675b0. |
thrau
approved these changes
Feb 15, 2023
Member
thrau
left a comment
There was a problem hiding this comment.
thank you! this is really helpful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we generated a list of all images which also included images such as
localstack/localstack:<none>, i.e. dangling images without tags assigned.Changes
:<none>before trying to update them.public.ecr.aws/lambda)Closes #7156