Change behavior of VtlTemplate to modify variable values in-place#7687
Merged
Change behavior of VtlTemplate to modify variable values in-place#7687
Conversation
silv-io
reviewed
Feb 15, 2023
Member
silv-io
left a comment
There was a problem hiding this comment.
LGTM, but some comments regarding dicts and deepcopy.
509846f to
e1a71d7
Compare
e1a71d7 to
5d0db6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change behavior of the
VtlTemplateutility class to modify variable values in-place. This PR is a prerequisite for an upstream PR that enhances support for AppSync pipeline resolvers.