fix encoding issues in router, proxy, partition rewriting#7682
Merged
alexrashed merged 2 commits intomasterfrom Feb 14, 2023
Merged
fix encoding issues in router, proxy, partition rewriting#7682alexrashed merged 2 commits intomasterfrom
alexrashed merged 2 commits intomasterfrom
Conversation
thrau
approved these changes
Feb 14, 2023
Member
thrau
left a comment
There was a problem hiding this comment.
LGTM! i think all we need to document somewhere is that @route and Router.add behave differently from werkzeug/flask now, in that we have to specify URL encoded paths now.
so @route("/foo bar/baz") has to become @route("/foo%20bar/baz"), if i understood correctly.
e23e64c to
2024a51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several encoding issues:
get_raw_base_urlnow avoids multi-encoding by avoiding the usage ofwerkzeug.sansio.utils.get_current_url.SimpleRequestsClientnow avoids multi-encoding by avoiding the usage ofwerkzeug.sansio.utils.get_current_url.Proxyuses the encoded path of the given request (instead of the decoded one) if noforward_pathis given.Routernow matches on the encoded path (instead of the decoded one)./<path:path>).ArnPartitionRewriteHandlernow uses the correct forward path (the modified one, instead of the original one).ArnPartitionRewriteHandlerdoes not decode string values anymore. It uses the encoding-specific regex if necessary anyways./cc @whummer