Skip to content

use lifecycle hook for registering lambda function URL routes#7668

Merged
thrau merged 1 commit intomasterfrom
lambda-lifecycle-hook
Feb 14, 2023
Merged

use lifecycle hook for registering lambda function URL routes#7668
thrau merged 1 commit intomasterfrom
lambda-lifecycle-hook

Conversation

@thrau
Copy link
Member

@thrau thrau commented Feb 12, 2023

This PR adds a ServiceLifecycleHook for the legacy lambda provider. This is to properly register lambda function URLs when persistence restores the service state, and will help in pro to unify persistence behavior into lifecycle hooks.

For community this has to significant effects other than the routes being registered a bit earlier now.

@thrau thrau temporarily deployed to localstack-ext-tests February 12, 2023 16:23 — with GitHub Actions Inactive
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

github-actions bot commented Feb 12, 2023

LocalStack integration with Pro

       3 files  +    1         3 suites  +1   1h 29m 15s ⏱️ + 2m 9s
1 725 tests ±    0  1 367 ✔️ +    3  358 💤  -     3  0 ±0 
2 439 runs  +365  1 741 ✔️ +202  698 💤 +163  0 ±0 

Results for commit 1c8b986. ± Comparison against base commit 2985ef4.

♻️ This comment has been updated with latest results.

@thrau
Copy link
Member Author

thrau commented Feb 13, 2023

still need to add it to pro and create a PR there as well :-)

@thrau thrau force-pushed the lambda-lifecycle-hook branch from c55b691 to 549accd Compare February 13, 2023 17:21
@thrau thrau temporarily deployed to localstack-ext-tests February 13, 2023 17:21 — with GitHub Actions Inactive
@thrau thrau force-pushed the lambda-lifecycle-hook branch from 549accd to 1c8b986 Compare February 13, 2023 19:33
@thrau thrau temporarily deployed to localstack-ext-tests February 13, 2023 19:33 — with GitHub Actions Inactive
@thrau thrau temporarily deployed to localstack-ext-tests February 13, 2023 19:50 — with GitHub Actions Inactive
@thrau thrau merged commit abe1ba0 into master Feb 14, 2023
@thrau thrau deleted the lambda-lifecycle-hook branch February 14, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants