Conversation
a8dc4e3 to
8b71473
Compare
8b71473 to
b6caf51
Compare
1022e64 to
233db5d
Compare
…igs" This reverts commit 2e97776.
233db5d to
c93cb22
Compare
Member
dominikschubert
left a comment
There was a problem hiding this comment.
Looks awesome 👍
just some smaller questions so far
10 tasks
To be fixed in follow-up PR and tested for lambda in general.
Add snapshot tests for version and alias to capture sid scope.
dominikschubert
approved these changes
Dec 28, 2022
Member
dominikschubert
left a comment
There was a problem hiding this comment.
Minor nit, otherwise LGTM though! 🥳
Feel free to merge after addressing it!
Good attention to detail and well documented 👍
Looking forward to the follow-up 😁
Member
Author
|
great, thanks for the suggestions @dominikschubert |
This was referenced Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests and fixes several TODOs related to Lambda permissions and ARN, qualifier handling, especially focusing on API validation and exception handling.
All changes apply to the new lambda provider enabled through
PROVIDER_OVERRIDE_LAMBDA=asfTODO: is this unique just in the policy or across all policies in region/account/function (?)inprovider.py)revision_idforremove_permissionrevision_idforadd_permissionlocalstack.services.awslambda.lambda_api.add_permission_policy_statement_validate_qualifier_expressionand_resolve_fn_qualifiercould be re-used in lambda (e.g., see TODOs increate_function_url_config)localstack.services.awslambda.api_utils.build_statement(hard to testTODO: add test for event_source_token (alexa smart home) and auth_type)Follow-Up (out of scope in this PR)
VersionFunctionConfiguration).