Add hot reloading for new lambda provider#7321
Merged
Conversation
Member
Author
Member
|
@dfangl I think We also sometimes use the prefix |
dominikschubert
approved these changes
Dec 16, 2022
Member
dominikschubert
left a comment
There was a problem hiding this comment.
minor nits, otherwise LGTM 👍
localstack/services/awslambda/invocation/docker_runtime_executor.py
Outdated
Show resolved
Hide resolved
thrau
approved these changes
Dec 16, 2022
Member
thrau
left a comment
There was a problem hiding this comment.
LGTM! i can see my comments from yesterday are already addressed :-)
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For efficient lambda development, we have to provide an easy solution to hot reload lambda functions, especially those of interpreted languages (like python and nodejs).
However, we want to make it available for all managed runtimes.
It should also only reset the environments if a change is detected, to prevent unnecessary initializations.
Breaking Changes with Fallbacks
__local__tohot-reload. The current provider will continue to support the__local__marker for now, the new one will only support the new one. Would move the deprecation to 1.4 and the removal to 2.0.Other Changes
Fixes #7200