Implement Lambda ASF container image CRUD and docker runtime executor hooks#7266
Merged
Implement Lambda ASF container image CRUD and docker runtime executor hooks#7266
Conversation
dominikschubert
approved these changes
Dec 2, 2022
Member
dominikschubert
left a comment
There was a problem hiding this comment.
minor nits in regards to hooks location and resource cleanup, otherwise LGTM 👍
localstack/services/awslambda/invocation/docker_runtime_executor.py
Outdated
Show resolved
Hide resolved
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Current implementation of the new lambda provider is missing relevant features regarding ImageUri CRUD.
Even though container image execution is a LocalStack Pro feature, the basic CRUD functionality should be in community, on the one hand to prevent tools which use them from throwing errors based on invalid API responses, and for the other to make a implementation easier for pro.
Changes