Add support for Lambda asynchronous event retries#7259
Merged
dominikschubert merged 17 commits intomasterfrom Dec 20, 2022
Merged
Add support for Lambda asynchronous event retries#7259dominikschubert merged 17 commits intomasterfrom
dominikschubert merged 17 commits intomasterfrom
Conversation
fadb089 to
3661abf
Compare
e9533fe to
b48ef3c
Compare
294a97a to
9d7794e
Compare
dfangl
approved these changes
Dec 19, 2022
Member
dfangl
left a comment
There was a problem hiding this comment.
LGTM! Just some minor test suggestion.
|
|
||
| # publish a version so we can have more than one entries for list ops | ||
| publish_version_result = lambda_client.publish_version(FunctionName=function_name) | ||
| snapshot.match("publish_version_result", publish_version_result) |
Member
There was a problem hiding this comment.
A get_function_event_invoke_config right after the publish, on the published version would be interesting. To verify if it sticks / has to be recreated.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes