Adapt stream event source listeners for ASF lambda provider#7110
Merged
dominikschubert merged 18 commits intomasterfrom Nov 22, 2022
Merged
Adapt stream event source listeners for ASF lambda provider#7110dominikschubert merged 18 commits intomasterfrom
dominikschubert merged 18 commits intomasterfrom
Conversation
9640654 to
719d4f5
Compare
9075dd6 to
6a47038
Compare
6a47038 to
02576af
Compare
02576af to
44d1dd3
Compare
…r kinesis/dynamodb
c62256d to
5783eee
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Eventtype)SYNCHRONOUS_*_EVENTS. We should always use the proper invocation types here since a lot of additional logic depends on them (e.g. destinations). The config setting forKINESISandSNSwas kept for now since those were still used in the code. They're being deprecated are only available in the old provider until 2.0Some cleanup/enhancements still open:
Use proper invoke and use the return code when passing payload to event source mapping destinations=> after the initial parity release