Update lambda runtime init version, add config option for timeouts#7087
Merged
Update lambda runtime init version, add config option for timeouts#7087
Conversation
…time exception to abc module
9cb396c to
5ddbee6
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We released a new version of the lambda runtime init, which we will now update to.
Also, the LambdaRuntimeException is better suited to live in the runtime_executor module (due to it potentially being used by multiple executor implementations).
And, for different executors, a config variable for the runtime environment timeout comes in handy.
Also, when an error is thrown in the start() method, we until now did not set this environment to failed, and stop any executor that might be running.
Changes
LAMBDA_RUNTIME_ENVIRONMENT_TIMEOUTconfig, which tells us the default timeout for an environment to report back (before it is killed and restarted). The default is 10, which should be enough for docker, but other executors might need more time here.LambdaRuntimeExceptionto runtime_executor module