Fix client warnings in logs for custom resources#6866
Merged
dominikschubert merged 1 commit intomasterfrom Sep 13, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly related to usage with PRO. With the changes in 20e9c0e users now started seeing warnings in the logs when deploying CloudFormation custom resources.
Example:
These warnings technically didn't break anything but caused a few reports already since users thought these might be related to other issues.
The root cause here was the removal of the
continuestatement and redundant execution ofget_clienteven after the execution of the function.