fix terraform AWS provider patch for terraform tests#6853
Merged
alexrashed merged 1 commit intomasterfrom Sep 12, 2022
Merged
Conversation
dominikschubert
approved these changes
Sep 12, 2022
Member
dominikschubert
left a comment
There was a problem hiding this comment.
LGTM 👍
Having a way to configure these via environment variable for example would be great indeed 😄
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 3baefea, @macnev2013 introduced an automation which automatically executes a set of terraform tests (created by the terraform community) against localstack.
The testing infrastructure depends on a small patch which is applied on top of https://github.com/hashicorp/terraform-provider-aws. Unfortunately, the patch broke with hashicorp/terraform-provider-aws@2b217fc.
This PR fixes the patch for now. In another iteration, we could make the testing infrastructure more resilient by: